Rollup of 2 pull requests #32531
Closed
Rollup of 2 pull requests #32531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Mar 27, 2016
Manishearth
commented
- Successful merges: derive: use discriminant_value in #[derive(Hash)] #32252, Improve concurrency chapter #32529
- Failed merges:
This is the same approach taken in rust-lang#24270, except that this should not be a breaking change because it only changes the output of hash functions, which nobody should be relying on.
derive: use discriminant_value in #[derive(Hash)] derive: use discriminant_value in #[derive(Hash)] Fixes rust-lang#21714. Spawned from rust-lang#32139. r? @alexcrichton
…klabnik Improve concurrency chapter Incorporate feedback from HN r? @steveklabnik
|
@bors r+ p=2 force |
|
📌 Commit 724b0b8 has been approved by |
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
|
⌛ Testing commit 724b0b8 with merge cb97950... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.